No vchan port sexp, and mirage-flow 4 support #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Missing pin? |
|
Yes and no. So, tls since 0.17.4 has a shutdown function. The CI here fails since vchan only since 6.0.2 (PRed to opam-repository) supports mirage-flow 4. So, once ocaml/opam-repository#25765 is merged, we'll hopefully get this CI check to be green and can merge and release a conduit with shutdown functionality :) |
|
CI looks fine, there's a failure in conduit_async.ml with OCaml 5.2: module V1 = V1
module V2 = V2
module V3 = V3
[@@@deprecated "Use Conduit_async.V1"]
include V1.Conduit_asyncand the error is "Error (warning 53 [misplaced-attribute]): the "deprecated" attribute cannot appear in this context" -- any hints where to put it - how to change the implementation? |
|
FreeBSD failures are tracked in janestreet/core_unix#11 |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Apr 30, 2024
CHANGES: * conduit-mirage: IPv6 literal * DNS support for default resolver (mirage/ocaml-conduit#425 @Firobe) * conduit-mirage: adapt to mirage-flow 4 API, requiring tls 0.17.4, vchan 6.0.2 (mirage/ocaml-conduit#424 @hannesm) * conduit-lwt-unix: disable deprecation alert (mirage/ocaml-conduit#424 @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.