Add ocamldoc generation and improve the Html.Create library #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction to the Html.Create module
…mentation in the HTML library
|
Thanks! Also you don't need to close and open a new pull-request every time you force push to your branch. GitHub associates pull-requests to branch, so if you update your branch it will automatically update the associated pull-request. |
…he last commit. we obviously don't want to waste user's time with all that junk when they can just produce it on their own, so I removed it
chrismamo1
force-pushed
the
gosh_darned_rebasing_and_also_actual_work
branch
from
9554282
to
0e7f9e8
Compare
|
Sorry, I'm aware of the automatic synchronization between this PR and my branch, but the old PR used my |
…sensible order. Also takes advantage of the potential benefits of partially applying this function.
… antiquotation in an HTML quotation.
…ml.Create.table's parameters to account for the new divide-and-conquer strategy of the function
|
thanks for all this work Chris! It'll be in a release shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt at merging my latest changes to the HTML and CSS libraries, as well as adding OCamlDoc to the Makefile.
The changes involve adding a table creation function to the
Html.Createmodule, which aims to be more robust (albeit less efficient) than the current table generation method. In the long-term, I would like to expand OCaml COW's existing facilities for the generation/manipulation of web pages from within OCaml, as lately this is becoming my favourite way to build web pages. I am declaring this intent in order to become somewhat less of a rogue-contributor, randomly adding code here and there without any real plan or coordination with the COW team.Another change which I would like to work towards integrating into the entire library sometime in the future is the addition of a
colortype to theCssmodule.@avsm and @samoht, you have been wonderfully patient with my incompetence and I swear one day I am going to bake you guys cookies.