test failure in CI on 4.04.2

[hannesm]

from https://api.travis-ci.org/v3/job/326030745/log.txt:

Processing 16/23: [�[32mppx_cstruct�[m: jbuilder runtest]
 jbuilder "runtest" "-p" "ppx_cstruct" "-j" "4" (CWD=/home/travis/.opam/4.04.2/build/ppx_cstruct.3.2.1)
         ppx ppx_test/pcap.pp.ml
         ppx ppx_test/enum.pp.ml
    ocamldep lib_test/tests.depends.ocamldep-output
         ppx ppx_test/basic.pp.ml
    ocamldep ppx_test/pcap.depends.ocamldep-output
         ppx ppx_test/pcap.pp.mli
      ocamlc lib_test/bounds.{cmi,cmo,cmt}
      ocamlc ppx_test/enum.{cmi,cmo,cmt}
    ocamldep ppx_test/pcap.dependsi.ocamldep-output
      ocamlc lib_test/tests.{cmi,cmo,cmt}
      ocamlc ppx_test/basic.{cmi,cmo,cmt}
      ocamlc ppx_test/pcap.{cmi,cmti}
    ocamlopt ppx_test/enum.{cmx,o}
    ocamlopt lib_test/tests.{cmx,o}
    ocamlopt lib_test/bounds.{cmx,o}
    ocamlopt ppx_test/basic.{cmx,o}
    ocamlopt ppx_test/pcap.{cmx,o}
    ocamlopt ppx_test/enum.exe
    ocamlopt lib_test/tests.exe
    ocamlopt ppx_test/basic.exe
        enum alias ppx_test/runtest
    ocamlopt lib_test/bounds.exe
       basic alias ppx_test/runtest
      bounds alias lib_test/runtest
.....................E..............................
 ==============================================================================
Error: bounds:21:test blit dst offset negative

(Failure test_blit_dst_offset_negative)
------------------------------------------------------------------------------
Ran: 52 tests in: 0.03 seconds.
FAILED: Cases: 52 Tried: 52 Errors: 1 Failures: 0 Skip:  0 Todo: 0 Timeouts: 0.
    ocamlopt ppx_test/pcap.exe
        pcap alias ppx_test/runtest
    ocamlopt .ppx/ppx_cstruct+ppx_sexp_conv/ppx.exe
         ppx ppx_test/with-sexp/ppx_cstruct_and_sexp.pp.ml
    ocamldep ppx_test/with-sexp/ppx_cstruct_and_sexp.depends.ocamldep-output
      ocamlc ppx_test/with-sexp/ppx_cstruct_and_sexp.{cmi,cmo,cmt}
    ocamlopt ppx_test/with-sexp/ppx_cstruct_and_sexp.{cmx,o}
       tests alias lib_test/runtest (got signal FPE)
(cd _build/default/lib_test && ./tests.exe)
..........

[talex5]

I guess it's because you're running the new tests against an old cstruct:

  ↘  downgrade cstruct                3.2.1 to 3.0.0  [required by nocrypto]
  ↻  recompile ppx_cstruct            3.2.1           [uses cstruct]

I guess ppx_cstruct should depend on a newer cstruct.

Might be worth investigating why nocrypto is forcing the use of a version of cstruct with missing bounds checks though.

[XVilka]

I guess this one can be closed?