Ensure make test runs all the tests
#92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch there were 2 distinct test suites: - `make test`: runs the tests from the _oasis file - `test.sh`: runs a set of shell script based tests The `opam` file only mentioned `test.sh`, so some of the tests were effectively hidden from travis (.. and initially from me too) Since the discussion on mirage#54 says that we're phasing out `test.sh`, this patch extends `make test` to call `test.sh` internally, and makes the `opam` file run `make test`. This ensures that travis (and developers) run all the tests rather than a subset. No-one need know about the details of `test.sh`, and we can take our time to refactor them. Fixes mirage#58 Signed-off-by: David Scott <dave.scott@docker.com>
djs55
added a commit
that referenced
this pull request
Mar 12, 2016
Ensure `make test` runs all the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch there were 2 distinct test suites:
make test: runs the tests from the _oasis filetest.sh: runs a set of shell script based testsThe
opamfile only mentionedtest.sh, so some of the tests wereeffectively hidden from travis (.. and initially from me too)
Since the discussion on #54 says that we're phasing out
test.sh,this patch extends
make testto calltest.shinternally, andmakes the
opamfile runmake test. This ensures that travis (anddevelopers) run all the tests rather than a subset. No-one need
know about the details of
test.sh, and we can take our time torefactor them.
Fixes #58
Signed-off-by: David Scott dave.scott@docker.com