Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

could mirage tests be using mirage-vnetif? #106

Closed
yomimono opened this issue Nov 2, 2016 · 2 comments
Closed

could mirage tests be using mirage-vnetif? #106

yomimono opened this issue Nov 2, 2016 · 2 comments
Labels
Milestone

Comments

@yomimono
Copy link
Contributor

yomimono commented Nov 2, 2016

The mock network modules in lib_test/ounit/test_mdns_responder_mirage have a lot of boilerplate and stubbed-out code. Could they be replaced by the mirage-vnetif library, which is intended to provide in-memory network stacks for testing?

avsm pushed a commit to avsm/ocaml-dns that referenced this issue Jun 23, 2017
Support for Async SSL connection parameters
@avsm
Copy link
Member

avsm commented May 9, 2019

Since #159 is merged, we don't have any test cases for the mirage- or lwt-specific backends (but extensive tests for the core suite). Leaving this open for a mirage-vnetif test suite for this library

@avsm avsm added the testing label May 9, 2019
@avsm avsm added this to the 2.0.0 milestone May 9, 2019
@hannesm
Copy link
Member

hannesm commented May 9, 2019

when adding mirage-vnetif based tests, please investigate first what you like to test... the mirage layer is rather slim (mainly tcp connection management), most of the server and resolver logic can be tested in a pure fashion -- no need for vnetif :)

@hannesm hannesm closed this as completed Jun 28, 2019
RyanGibb pushed a commit to RyanGibb/ocaml-dns that referenced this issue Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants