Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stub implement pseudoheader, now required by mirage-types #94

Merged
merged 1 commit into from Jun 22, 2016
Merged

stub implement pseudoheader, now required by mirage-types #94

merged 1 commit into from Jun 22, 2016

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Jun 16, 2016

@yomimono this makes the tests compile (for some reason the Dns_resolver_unix::resolution-error test fails on my FreeBSD)

@hannesm
Copy link
Member Author

hannesm commented Jun 16, 2016

nearly all builds completed successfully; only some alpine-3.3 couldn't compile lwt...

@samoht
Copy link
Member

samoht commented Jun 16, 2016

yes the alpine error is because they lwt configuration script needs ncurse which is not installed by default there ... @avsm and I tracked that issue yesterday, should be fixed soon.

@yomimono
Copy link
Contributor

Thanks for this @hannesm :) I've restarted the tests; we'll see how they do.

@hannesm
Copy link
Member Author

hannesm commented Jun 17, 2016

there was only a single failing build, you can restart individual builds... all others were fine

@yomimono
Copy link
Contributor

Ah, thanks, I didn't realize that - barely noticed the "restart" button on the main page, let alone within the individual builds. I'll waste less compute cycles next time.

@hannesm
Copy link
Member Author

hannesm commented Jun 17, 2016

(and the alpine build is unlikely to be working before something like ocaml/opam-repository#6791 gets merged)

@hannesm
Copy link
Member Author

hannesm commented Jun 17, 2016

same as yesterday, IMHO this can safely be merged since all other platforms are happy (and it fixes make test with mirage-types master).

@hannesm hannesm merged commit cc738ee into mirage:master Jun 22, 2016
@hannesm hannesm deleted the fix-pseudoheader branch June 22, 2016 13:57
@hannesm
Copy link
Member Author

hannesm commented Jun 22, 2016

merged this minor fix (won't fix your alpine opam troubles, but there are several issues in the opam repository)

avsm pushed a commit to avsm/ocaml-dns that referenced this pull request Jun 23, 2017
Expose a ?version arg in Conduit_async_ssl.ssl_listen, default being …
RyanGibb pushed a commit to RyanGibb/ocaml-dns that referenced this pull request Sep 26, 2022
Remove the irmin+mirage custom release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants