fat bin using the block --buffered arg for connect #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mirage-block-unix.2.5.0 has an arg to specify the use of unbuffered IO (
O_DIRECT
flag on open) onconnect
, an optional--buffered
. This change uses that instead of the current appending of "buffered:" in front of the file name. This fixes #64.Also, was looking at mirage-block-solo5, and it doesn't implement the
--buffered
arg. The fat bin tool uses block-unix, so that's good, but we should really implement that arg in solo5.Test: