Fix #342 (WIP) #350
Closed
Fix #342 (WIP) #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ide PKT-line and use p_http_report_status in TCP flow (wip)
Merged
|
Close by #351 |
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Jul 12, 2019
CHANGES: - Move to the last version of `decompress` (@dinosaure, mirage/ocaml-git#366) - Check order of entries in a tree object (bug found by @samoht, fixed by @dinosaure, mirage/ocaml-git#365) - Use `mmap` package (@dinosaure, mirage/ocaml-git#347, mirage/ocaml-git#360) - Update README.md (@tcoopman, @dinosaure, mirage/ocaml-git#337, mirage/ocaml-git#359) - `trim` the window used to pack (@pqwy, @dinosaure, mirage/ocaml-git#357, mirage/ocaml-git#358) - Use lastest version of `lru.0.3.0` (@pqwy, @dinosaure, mirage/ocaml-git#352, mirage/ocaml-git#356) - Fix smart protocol (fixed by @clecat and @dinosaure, feedbacks from @hannesm) * Pull-request mirage/ocaml-git#351, mirage/ocaml-git#350, mirage/ocaml-git#338 * Issues mirage/ocaml-git#335, mirage/ocaml-git#342, mirage/ocaml-git#346 + regression tests was added (@dinosaure) + semantics about negociation was explained (@clecat) + end-to-end tests partially done (@hannesm) - Remove `sexplib` dependency (@samoht, mirage/ocaml-git#349) - Fix smart protocol to accept empty response from `ls-remote` (bug found by @hannesm, fixed by @dinosaure, mirage/ocaml-git#348) - Add `io-page-unix` as dependency to tests `git-mirage` (@dinosaure, mirage/ocaml-git#345) - Remove deprecated `Cstruct.add_len` (replaced by `ke`) (@dinosaure, mirage/ocaml-git#345) - Use `Uri.user_info` to be able to be authentified by a service like GitHub (@linse, review by @dinosaure, mirage/ocaml-git#341, mirage/ocaml-git#343) - avoid clash between `digestif.c` and `digestif.ocaml` implementation (same for `checkseum`) * remove implementation dependencies on `git-unix` and `git-mirage` (bug found by @hannesm and @linse, fixed by @dinosaure, mirage/ocaml-git#339) This update should be fixed by `dune`'s variants and `>= digestif.0.7.2` and `>= checkseum.0.1.0` - **breaking-change** add `etmp` as already-allocated buffer to encode Git object (@dinosaure, mirage/ocaml-git#336) * add `ke.0.3` as new dependency - consumed inputs for every entries in a tree (bug found by @zspicko, fixed by @dinosaure, mirage/ocaml-git#334)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR come from a reverse engineering about Smart protocol where technical documentation does not notice me about a
PKT-lineinside aPKT-linewhen we compute a TCP flow. In some way, this PR should be more close togitwhere we mergep_http_report_status(a special case on the HTTP flow) andp_report_status(the initial case explained by technical documentation) - indeed, this is what Git does about HTTP overlay, it wraps TCP flow with an internal state to be stateless over HTTP (yes, it's ****).I tried this with
git.2.7.4only on TCP. @hannesm could you try to test this PR withcaldavover HTTP ? In my mind, it should not work ...If it's work, I will rewrite this PR to be more clean (and remove the special case about HTTP).