Properly expose github-jsoo and add missing dependencies #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Everything but the rename looks good. Shouldn't the module be |
|
@rgrinberg I am trying to reflect what we do in |
|
I see. So I guess this will need variants support to fully work. |
rgrinberg
approved these changes
Apr 9, 2018
|
varianttsssssssssssss |
avsm
added a commit
to avsm/opam-repository
that referenced
this pull request
Dec 12, 2018
CHANGES: - Port to latest Atd 2.0.0 interfaces (mirage/ocaml-github#218 by @mjambon and @avsm) - Port build system to Dune (@avsm) - Properly expose the GitHub JavaScript library and fix dependencies (mirage/ocaml-github#216 by @samoht) - Add `pull.merge_commit_sha` (mirage/ocaml-github#217 from @AltGr) - Convert local opam files to the 2.0 format. (@avsm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.