Support large result sets #14
Open
+74
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Scott <dave@recoil.org>
Every time the callback is called there is a "more results expected" flag. If the final one of these is true then we have to call `DNSServiceProcessResult` a.k.a. `query_result` again to accumulate the full result list. Signed-off-by: David Scott <dave@recoil.org>
djs55
added a commit
to djs55/vpnkit
that referenced
this pull request
Apr 3, 2019
This incorporates mirage/ocaml-osx-dnssd#14 backported to the opam-1.2 branch. Signed-off-by: David Scott <dave.scott@docker.com>
djs55
added a commit
to djs55/vpnkit
that referenced
this pull request
Apr 3, 2019
This incorporates mirage/ocaml-osx-dnssd#14 backported to the opam-1.2 branch. Signed-off-by: David Scott <dave.scott@docker.com>
The complication here is that when there are more result, we need to return a flag to the caller so they can `select` on the file descriptor again to wait for more results. This means the LowLevel API has to be changed. Signed-off-by: David Scott <dave@recoil.org>
djs55
added a commit
to djs55/vpnkit
that referenced
this pull request
Apr 5, 2019
This incorporates mirage/ocaml-osx-dnssd#14 backported to the opam-1.2 branch. Signed-off-by: David Scott <dave.scott@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the result set is large (> 1500 bytes?) then the callback is called with the
kDNSServiceFlagsMoreComingflag set meaning that we should callDNSServiceProcessResultagain to accumulate all the results.