Fix infinite loop enlarging the refcount table #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function `max_refcount_table_size` will return a size suitable for refcounting the data blocks, but not the refcount blocks (recall that the refcount table entries point to clusters which contain the reference counts). It will also fail to take into consideration the fact that the file may legitimately have holes in. This patch fixes an infinite loop caused when re-allocating the refcount table _to the same size it already is_ by guaranteeing that the table will be doubled in size in this case. This is related to mirage#8 Signed-off-by: David Scott <dave.scott@unikernel.com>
Signed-off-by: David Scott <dave.scott@unikernel.com>
This is intended to let you read small amounts of data at a time (e.g. up to a few KiB) Signed-off-by: David Scott <dave.scott@unikernel.com>
djs55
added a commit
that referenced
this pull request
Nov 9, 2015
Fix infinite loop enlarging the refcount table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readandwrite