Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with type-conv 3.0.1 #5

Closed
djs55 opened this issue Sep 28, 2011 · 4 comments
Closed

Incompatibility with type-conv 3.0.1 #5

djs55 opened this issue Sep 28, 2011 · 4 comments
Assignees

Comments

@djs55
Copy link
Member

djs55 commented Sep 28, 2011

Hi,

I tried upgrading to ocaml 3.12.1 and type-conv 3.0.1 and get this strange error:

bash-3.2# cat > foo.ml
module type Foo = sig end

bash-3.2# ocamlc -i foo.ml
module type Foo = sig  end

bash-3.2# ocamlfind ocamlc -syntax camlp4o -package rpc-light,rpc-light.syntax -i foo.ml
File "foo.ml", line 1, characters 22-25:
Parse error: "with_gen" expected after [module_type] (in [str_item])
File "foo.ml", line 1, characters 0-1:
Error: Preprocessor error
@avsm
Copy link
Member

avsm commented Sep 28, 2011

oh FFS, I think I just accidentally downgraded type-conv in Mirage, since the latest version on the Jane Street site is 2.3.0. Hunting down 3.0.1 now :-)

@ghost ghost assigned samoht Sep 28, 2011
@samoht
Copy link
Member

samoht commented Sep 28, 2011

no idea what it is, I guess I should investigate on this later :-)

samoht added a commit that referenced this issue Nov 2, 2011
@samoht
Copy link
Member

samoht commented Nov 2, 2011

Actually the bug came from Jon's experimental branch (as mine didn't have the with_gen stuff): I've merged his tree in mine and I think I fixed the issue correctly.

Please re-open this ticket if my fix is not sufficient.

@samoht samoht closed this as completed Nov 2, 2011
@djs55
Copy link
Member Author

djs55 commented Nov 2, 2011

On Wed, Nov 2, 2011 at 2:01 PM, Thomas Gazagnaire
reply@reply.github.com
wrote:

Actually the bug came from Jon's experimental branch (as mine didn't have the with_gen stuff): I've merged his tree in mine and I think I fixed the issue correctly.

Please re-open this ticket if my fix is not sufficient.

Thanks! I'll take a look at this later today -- most people are off
skiing so this is a good time to start upgrading things :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants