Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry, I wasn't carefully trying #52 on BSD.
It turns out that the expression
sed -e '1i ('
(anda
) does not work with BSD sed:I found some explanation here, using the proposed
sed -e '1 i\'$'\n''('
works in a shell, but via the Makefile leads to a leading$
on a Linux (debian) system -- it works fine on FreeBSD :/Instead, we can use sed replacements (and shell invocation) as done in this PR, and provide the parens in the
.in
files.(Another solution I came up with is another conditional in Makefile:
and then
sed -e '1 i$(SED_POST)('
in the rules, but IMHO that one is less readable than the provided diff).