Skip to content

Commit

Permalink
Add Fastboot to addon blacklist for dummy app (#2004)
Browse files Browse the repository at this point in the history
We have ember-cli-fastboot installed so it can be made available to some
of the test projects, but we never use it to actually serve the dummy
app (which is the docs app).

Thus, if a new user clones + runs the repo, unless they have the
FASTBOOT_DISABLED ENV var set, `ember s` will try to serve the
dummy app via FastBoot which will cause errors.

With the addon blacklisted, ember-cli-fastboot will just never be able
to affect the dummy app at all.
  • Loading branch information
samselikoff committed Jul 2, 2020
1 parent 780f283 commit fabd388
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions ember-cli-build.js
Expand Up @@ -2,17 +2,20 @@

const EmberAddon = require("ember-cli/lib/broccoli/ember-addon");

module.exports = function(defaults) {
module.exports = function (defaults) {
let app = new EmberAddon(defaults, {
"ember-cli-babel": {
includePolyfill: true
includePolyfill: true,
},
"ember-cli-addon-docs-esdoc": {
packages: [
"ember-cli-mirage",
{ name: "miragejs", sourceDirectory: "lib" }
]
}
{ name: "miragejs", sourceDirectory: "lib" },
],
},
addons: {
blacklist: ["ember-cli-fastboot"],
},
});

/*
Expand Down

0 comments on commit fabd388

Please sign in to comment.