Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Customizing the inflector docs #1912

Merged
merged 1 commit into from Mar 26, 2020
Merged

Update Customizing the inflector docs #1912

merged 1 commit into from Mar 26, 2020

Conversation

yratanov
Copy link
Contributor

fixes #1911

@samselikoff samselikoff merged commit 07e3077 into miragejs:master Mar 26, 2020
@samselikoff
Copy link
Collaborator

Thanks! And woops - actually didn't mean to merge this, wanted to ask why you made it into diff?

@samselikoff
Copy link
Collaborator

I think we should keep it js and just add a sentence below that says something like "Make sure to use before: "ember-cli-mirage" so this runs before Mirage initializes itself."

@yratanov
Copy link
Contributor Author

@samselikoff I'll update

yratanov added a commit to yratanov/ember-cli-mirage that referenced this pull request Mar 28, 2020
@yratanov
Update Customizing the inflector docs [2]
027138b 
Apply feedback from miragejs#1912
@yratanov yratanov mentioned this pull request Mar 28, 2020
Merged
samselikoff pushed a commit that referenced this pull request Mar 31, 2020
@yratanov
Update Customizing the inflector docs [2] (#1917)
e243aa6 
Apply feedback from #1912
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inflector initializer file name matters
2 participants
@yratanov @samselikoff