Remove deprecated miragejs re-exports
#2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cah-brian-gantzler
approved these changes
Jan 14, 2022
|
Looks like we have to cleanse the test apps from using the deprecated exports as well.. Example. https://github.com/miragejs/ember-cli-mirage/blob/master/test-projects/01-basic-app/tests/acceptance/ember-data-test.js#L3 |
SergeAstapov
force-pushed
the
remove-deprecated-imports
branch
from
c9a9828
to
c856223
Compare
cah-brian-gantzler
approved these changes
Jan 21, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PRs #2256 and #2244 re-exports from
miragejspackage were deprecated and released in version v2.3.0This PRs deletes deprecated re-exports making
ember-cli-miragethinner layer on top ofmiragejs