Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure into monorepo #2395

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Restructure into monorepo #2395

merged 1 commit into from
Apr 22, 2022

Conversation

SergeAstapov
Copy link
Collaborator

No description provided.

@SergeAstapov SergeAstapov force-pushed the monorepo branch 4 times, most recently from 21a3329 to 2f6f64f Compare April 15, 2022 20:10
@cah-brian-gantzler
Copy link
Collaborator

What is the difference between test-packages and test-projects?

This appears to keep the actual test still in dummy in the addon. Future restructure to to extract that to a test-app as well?

@SergeAstapov
Copy link
Collaborator Author

What is the difference between test-packages and test-projects?

technically none.
Since we introduce packages folder (which is widely used for monorepos) makes sense just to rename "projects" in to "packages" for consistency

This appears to keep the actual test still in dummy in the addon. Future restructure to to extract that to a test-app as well?
Correct! Kept PR focused as extracting dummy app into test app would take another ~100 files changes

@cah-brian-gantzler
Copy link
Collaborator

I may have misread the PR, so many files changed. It looked like the end result would have both, didnt notice it was just a rename, wouldnt have ask. will look some more

@cah-brian-gantzler
Copy link
Collaborator

The scripts like link.sh used to share the node_modules amoung all the projects. With the workspaces assuming the scripts are no longer needed. Nice

@cah-brian-gantzler
Copy link
Collaborator

It seems this file https://github.com/miragejs/ember-cli-mirage/pull/2395/files#diff-f79b9ecbffd42f337bfa51417cd40e5a274ce039d5042b27cc64cebf1558a1a0 was a .gitkeep renamed to ci.yml but thinking this file and directory should not be here. Could be misreading PR again

@SergeAstapov SergeAstapov marked this pull request as ready for review April 15, 2022 21:05
cah-brian-gantzler
cah-brian-gantzler approved these changes Apr 17, 2022
View reviewed changes
Copy link
Collaborator

@cah-brian-gantzler cah-brian-gantzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there suppose to be an empty file at `packages/ember-cli-mirage/.github/workflows/ci.yml?

Other than that, looked, lotta file changes obviously. But seems correct for what i could see

@SergeAstapov
Copy link
Collaborator Author

Is there suppose to be an empty file at `packages/ember-cli-mirage/.github/workflows/ci.yml?

it was already removed, thanks for noticing!

@SergeAstapov SergeAstapov merged commit 2b440f4 into master Apr 22, 2022
@SergeAstapov SergeAstapov deleted the monorepo branch April 22, 2022 19:48
@SergeAstapov SergeAstapov mentioned this pull request Apr 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cah-brian-gantzler cah-brian-gantzler cah-brian-gantzler approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SergeAstapov @cah-brian-gantzler