Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Lodash usage #82

Open
samselikoff opened this issue Aug 22, 2019 · 2 comments
Open

Better Lodash usage #82

samselikoff opened this issue Aug 22, 2019 · 2 comments
Labels
Feature / Enhancement New feature or request

Comments

@samselikoff
Copy link
Contributor

In #77 we pulled in individual lodash packages instead of lodash-es but it's kinda lousy dev experience. Would love to get our setup better so we can just use lodash-es but get tree-shaking working!

@samselikoff samselikoff added the Feature / Enhancement New feature or request label Aug 22, 2019
@FLGMwt
Copy link

FLGMwt commented Sep 10, 2019

agreed, the extra modules to import and deps aren't super fun. I mostly worked on apps and not libs so I don't know if there's a difference, but I've used https://www.npmjs.com/package/babel-plugin-lodash in the past for the the same thing. Does that play nice w/ rollup'd packages? I'll spike it out to see if the bundle is the same

@samselikoff
Copy link
Contributor Author

It really should come "for free" once we have our build setup working correctly. The problem was our UMD build had all of lodash. Would love to see what you come up with!

We're also talking about trying out tsdx because (a) our build setup is screwed up right now (b) it is a huge pain to work on it (c) we want to add typescript support eventually and that will just complicate things further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature / Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants