Fixed assert about changing Pretender config. Ensured trackRequest was set properly #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems there is a test that actually checks that the assert is thrown. Rather than remove the assert, will see if code can be restructured to still make the assert possible |
…anging tracked requests after pretender is created
cah-brian-gantzler
force-pushed
the
trackRequests
branch
from
36528ba
to
4699b18
Compare
|
I have made these same changes in |
IanVS
approved these changes
Jun 1, 2022
| @@ -129,7 +131,8 @@ export default class PretenderConfig { | |||
| } | |||
|
|
|||
| let didOverridePretenderConfig = | |||
| config.trackRequests !== undefined && this.pretender; | |||
| config.trackRequests !== undefined && | |||
| config.trackRequests !== this.trackRequests; | |||
There was a problem hiding this comment.
So, instead of checking whether there's a pretender instance, we look to see whether the trackRequests has changed. This makes sense, although the name of didOverridePretenderConfig feels overly broad for what's actually being checked. But, I think that's fine.
There was a problem hiding this comment.
Its a local var, I was just changing the minimum
IanVS
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the assert that informed you could not change the trackRequests after pretender is created.
After moving things around, the value of tracked Request was being sent into pretender via a function. The value in the function was being set too late. Since the value was already known, just simplified as putting it behind a function served no purpose.
Fixes #1043