Add a type for findBy with a predicate function #793

gentoid · 2021-02-18T14:01:42Z

Fixes #665

samselikoff · 2021-02-18T15:01:47Z

Thank you! Looks like there's a TS test failure. (I don't know TS yet but just wanted to point this out.)

gentoid · 2021-02-18T15:24:32Z

yeah. Interestingly enough that locally this had passed. Going to investigate it.

IanVS · 2021-10-04T14:04:07Z

@gentoid we've fixed failing tests on master and updated our CI infrastructure. Would you be willing to rebase this PR on latest master?

gentoid · 2021-10-04T15:19:34Z

@IanVS I'll check it

gentoid · 2021-10-14T07:19:10Z

@IanVS it's been rebased. Could someone please review?

IanVS · 2021-10-14T14:56:56Z

It looks like a type test is failing, would you mind taking a look, @gentoid? Thanks!

gentoid · 2021-10-25T06:33:01Z

Hi there. Due to personal reasons I cannot finish this PR. I'm sorry. Please feel free to "take the baton" or close it.

Thanks

IanVS · 2021-10-25T11:37:06Z

No worries, thanks for the work here, and for the update.

gentoid force-pushed the fix/type-for-find-by branch from 645c7a4 to 5ce11d3 Compare October 13, 2021 19:12

gentoid added 2 commits December 2, 2021 11:04

Add TS type for Schema.findBy for the case with a predicate function

f52f579

Add a test case for Schema.findBy where it accepts a predicate function

0caa95f

IanVS force-pushed the fix/type-for-find-by branch 2 times, most recently from 828fcb8 to fd80dbe Compare December 2, 2021 16:49

Fix test, add docs

35547c6

IanVS force-pushed the fix/type-for-find-by branch from fd80dbe to 35547c6 Compare December 2, 2021 16:52

IanVS merged commit 3f16f50 into miragejs:master Dec 2, 2021

Provide feedback