Add type for head request handler #977
Conversation
|
@samselikoff this is a pretty small and straightforward PR to update some typescript. Mind taking a quick look when you have a chance? Thanks! |
|
@IanVS happy to merge but looks like build is failing :( I think it's been failing for a while & we haven't cut a release in a while. Any help fixing master would be the fastest way to get this in there! |
|
Thanks @samselikoff, I did in fact push up a PR to fix the build failure, as well. :). #984 |
IanVS
force-pushed
the
head-route-handler
branch
from
60e69b0
to
7a1f315
Compare
|
Invited you to the repo, so I don't block you in the future :) (No pressure to help out anywhere else of course). Thanks again! Should be able to merge after new tests run |
|
Ok why don't you pull the trigger! |
|
Can also run through how we release too, if you have the cycles. Would be really great to get this written down so I'm not a blocker anymore |
|
👍 I sent you an email. |
I found that miragejs handles
this.headroute handlers just fine, but the signature was missing from the types. So this adds it.