Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade and lock-down prettier version #988

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Upgrade and lock-down prettier version #988

merged 2 commits into from
Oct 1, 2021

Conversation

IanVS
Copy link
Collaborator

@IanVS IanVS commented Oct 1, 2021

This is an upgrade of prettier from 2.2.1 to 2.4.1. I also locked down the package.json, as prettier recommends, because any change to the version can cause formatting differences so it's best to be intentional about upgrades.

This PR also includes the results of running the new version of prettier, which made a few formatting changes, but not a ton.

@IanVS IanVS requested a review from samselikoff October 1, 2021 12:40
@IanVS
Copy link
Collaborator Author

IanVS commented Oct 1, 2021

I'm not sure why CI isn't running on this PR...

@IanVS
Copy link
Collaborator Author

IanVS commented Oct 1, 2021

It looks like travis is out of credits (I thought it was free for OSS...). It says something about being able to alter a Consume paid credits for OSS setting. But I don't have privileges to do so.

I can explore setting up github actions to run tests instead of travis, and perhaps we can leave travis to only handle releases? Or eventually move that to github actions as well, but I think we can move a piece at a time.

@samselikoff
Copy link
Contributor

Really strange, never seen this before. GH actions would be awesome! Travis is def just there for historical reasons.

image

Thanks so much for your help, if you know how to fix this on Travis (seems like its a bug or theres just a switch I have to flip somewhere to get more oss credits) I can help, but if you're down to get GH actions working go for it!!

@IanVS
Copy link
Collaborator Author

IanVS commented Oct 1, 2021

I've opened #990 to add github actions for lint + test.

@IanVS IanVS merged commit 72b505e into master Oct 1, 2021
@IanVS IanVS deleted the upgrade-prettier branch October 1, 2021 14:16
@samselikoff
Copy link
Contributor

Boom! Nice work 🚂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants