Update dtslint to 4.1.6 #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanVS
force-pushed
the
upgrade-typescript
branch
from
a5c07c0
to
b224508
Compare
IanVS
commented
Oct 1, 2021
| }, | ||
| "engines": { | ||
| "node": "6.* || 8.* || >= 10.*" | ||
| }, | ||
| "resolutions": { | ||
| "@definitelytyped/typescript-versions": "0.0.89" |
There was a problem hiding this comment.
This was necessary to avoid the yarn error:
Pattern ["@definitelytyped/typescript-versions@latest"] is trying to unpack in the same destination "/Users/ianvs/Library/Caches/Yarn/v6/npm-@definitelytyped-typescript-versions-0.0.89-815ba4ec6e2e0486e0d192ba19d7359cd9610f38-integrity/node_modules/@definitelytyped/typescript-versions" as pattern ["@definitelytyped/typescript-versions@^0.0.89","@definitelytyped/typescript-versions@^0.0.89","@definitelytyped/typescript-versions@^0.0.89"]. This could result in non-deterministic behavior, skipping.
samselikoff
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the version of dtslint from 4.0.6 to 4.1.6.
It also removes the direct dependency on typescriptEdit: That didn't work out, typescript does seem to still need to be installed for dtslint to run.