Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transitive dependencies #996

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Update transitive dependencies #996

merged 1 commit into from
Oct 1, 2021

Conversation

IanVS
Copy link
Collaborator

@IanVS IanVS commented Oct 1, 2021

Now that all of our direct dependencies are updated, this PR updates all of the transitive dependencies (sub-dependencies). I did this by deleting the yarn.lock file, and re-creating it. This allows semver to do its thing and de-duplicate as many dependencies as possible, which actually reduces the total number of packages installed in the mirage repo from 1024 to 960.

This isn't something I'd recommend doing all the time, but every once in a while I think it's good cleanup to do.

Base automatically changed from upgrade-buildchain to master October 1, 2021 18:56
@IanVS IanVS requested a review from samselikoff October 1, 2021 18:57
@IanVS IanVS changed the title Update rollup, babel, core-js Update transitive dependencies Oct 1, 2021
@samselikoff
Copy link
Contributor

Yep totally agree! I wanted to add something to do this regularly actually because you can get in a bad spot with outdated yarn.locks. I've had to manually bisect lockfiles to find problematic deps before... I'll have to tell you about it sometime :)

@IanVS IanVS merged commit 83b12cc into master Oct 1, 2021
@IanVS IanVS deleted the indirect-deps branch October 1, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants