Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip canHandle #159

Closed
wants to merge 2 commits into from
Closed

wip canHandle #159

wants to merge 2 commits into from

Conversation

samselikoff
Copy link
Contributor

No description provided.

@samselikoff
Copy link
Contributor Author

Additional tests:

  • dynamic segment
  • resource helper
  • wildcards *

@samselikoff samselikoff changed the title wip wip canHandle Nov 21, 2019
@zeppelin
Copy link

zeppelin commented Dec 2, 2019

@samselikoff this means that Mirage currently won't allow overriding handlers on an already established server?

@samselikoff
Copy link
Contributor Author

@zeppelin nope this is for something different.

You can override handlers for sure, I do it all the time in tests, for example to test errors: https://miragejs.com/docs/testing/application-tests#testing-errors

@zeppelin
Copy link

zeppelin commented Dec 2, 2019

@samselikoff hmm, currently trying to get it work, but I always get the original handler called. Something else must be off then in my setup...

@samselikoff
Copy link
Contributor Author

Closing as this is outdated, but keeping reference in the Node tracking issue: #210

@ryanto ryanto mentioned this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants