Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor-out GenericsCapableSignatureReader from TypeInvoker. #429

Merged

Conversation

felixvf
Copy link
Contributor

@felixvf felixvf commented Mar 1, 2016

The TypeInvoker is actually misused as a GenericsCapableSignatureReader, doing functionality of both type incoking and reading signatures, but in both cases not performing that functionality perfectly, especially in this method:

  def saveTypeParam(var)
    typeVariables[var.toString] = @args.removeFirst unless @args.isEmpty
    @typeParams.add(var)
  end

Hence, the old TypeInvoker performing 2 distinct functions should be split into the new TypeInvoker and a GenericsCapableSignatureReader.

@felixvf felixvf force-pushed the cleanup_generics_capable_signature_reader branch from 43395ce to c8c845a Compare March 1, 2016 16:42
@felixvf felixvf merged commit 8e9907a into mirah:master Dec 7, 2016
@felixvf felixvf deleted the cleanup_generics_capable_signature_reader branch December 7, 2016 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant