Respect ANDROID_HOME if set #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| abort "\"android\" executable not found on $PATH" if tools.nil? | ||
| real_location = Pathname.new("#{tools}/android").realpath.dirname | ||
| File.expand_path("#{real_location}/..") | ||
| if ENV["ANDROID_HOME"] == "" then |
There was a problem hiding this comment.
Could you change this to check for falsyness? When an ENV var isn't set, it's nil. Maybe something like:
return ENV["ANDROID_HOME"] if ENV["ANDROID_HOME"]followed by the original implementation would be better.
|
Sorry, I haven't used Ruby in a while. :) |
|
Thanks for the contribution, @Arcterus! I have a few other code changes staged for the upcoming 0.1.3 release this week, so let me review this before I merge your changes into master so we don't have any conflicts. :-) |
ghost
assigned 
|
LOL, no worries, @Arcterus! I've merged your change into master. Let me know if it doesn't work for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the SDK path is determined like this, then it will be more user-friendly (I won't have to restructure my path just to get pindah to work).