Return false for empty comments, true if comment was added (#524)

miraheze · May 4, 2024 · 00f1511 · 00f1511
1 parent 5cffb94
commit 00f1511
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/includes/RequestWiki/WikiRequest.php b/includes/RequestWiki/WikiRequest.php
@@ -109,10 +109,10 @@ public function __construct( int $id = null, CreateWikiHookRunner $hookRunner =
 		}
 	}
 
-	public function addComment( string $comment, UserIdentity $user, string $type = 'comment', array $notifyUsers = [] ) {
+	public function addComment( string $comment, UserIdentity $user, string $type = 'comment', array $notifyUsers = [] ): bool {
 		// don't post empty comments
 		if ( !$comment || ctype_space( $comment ) ) {
-			return;
+			return false;
 		}
 
 		$this->dbw->insert(
@@ -134,6 +134,8 @@ public function addComment( string $comment, UserIdentity $user, string $type =
 		}
 
 		$this->sendNotification( $comment, $notifyUsers, $type );
+
+		return true;
 	}
 
 	private function sendNotification( string $comment, array $notifyUsers, string $type = 'comment' ) {