Escape some more interface messages

miraheze · Feb 9, 2024 · 2ef0f50 · 2ef0f50
1 parent 886cc6b
commit 2ef0f50
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/includes/FormFactory/ManageWikiFormFactoryBuilder.php b/includes/FormFactory/ManageWikiFormFactoryBuilder.php
@@ -670,16 +670,16 @@ private static function buildDescriptorPermissions(
 		$rowsBuilt = [];
 
 		foreach ( $groupData['allGroups'] as $group ) {
-			$rowsBuilt[UserGroupMembership::getGroupName( $group )] = $group;
+			$rowsBuilt[htmlspecialchars( UserGroupMembership::getGroupName( $group ) )] = $group;
 		}
 
 		$formDescriptor['group-matrix'] = [
 			'type' => 'checkmatrix',
 			'columns' => [
-				wfMessage( 'managewiki-permissions-addall' )->text() => 'wgAddGroups',
-				wfMessage( 'managewiki-permissions-removeall' )->text() => 'wgRemoveGroups',
-				wfMessage( 'managewiki-permissions-addself' )->text() => 'wgGroupsAddToSelf',
-				wfMessage( 'managewiki-permissions-removeself' )->text() => 'wgGroupsRemoveFromSelf'
+				wfMessage( 'managewiki-permissions-addall' )->escaped() => 'wgAddGroups',
+				wfMessage( 'managewiki-permissions-removeall' )->escaped() => 'wgRemoveGroups',
+				wfMessage( 'managewiki-permissions-addself' )->escaped() => 'wgGroupsAddToSelf',
+				wfMessage( 'managewiki-permissions-removeself' )->escaped() => 'wgGroupsRemoveFromSelf'
 			],
 			'rows' => $rowsBuilt,
 			'section' => 'group',