Continue if setting is unknown

miraheze · May 24, 2020 · d3fa6bd · d3fa6bd
1 parent a9f325f
commit d3fa6bd
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/includes/formFactory/ManageWikiFormFactoryBuilder.php b/includes/formFactory/ManageWikiFormFactoryBuilder.php
@@ -1017,6 +1017,11 @@ private static function submissionSettings(
 
 		$permissionManager = MediaWikiServices::getInstance()->getPermissionManager();
 		foreach ( $wgManageWikiSettings as $name => $set ) {
+			// No need to do anything if setting does not 'exist'
+			if ( !isset( $formData[$name] ) ) {
+				continue;
+			}
+
 			$current = $settingsList[$name];
 			$mwAllowed = ( $set['restricted'] && $permissionManager->userHasRight( $context->getUser(), 'managewiki-restricted' ) || !$set['restricted'] );
 			$type = $set['type'];