Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always guarantee realname is removed #54

Merged
merged 6 commits into from Apr 3, 2022
Merged

Conversation

Universal-Omega
Copy link
Sponsor Member

May be some circumstances it isn't, this should guarantee that it is.

May be some circumstances it isn't, this should guarantee that it is.
@Reception123
Copy link

@Universal-Omega Hmm, seems checks are failing

@Universal-Omega
Copy link
Sponsor Member Author

@Universal-Omega Hmm, seems checks are failing

Yeah, unrelated though. I know why. Its an upstream issue with latest docker image tag.

@dmehus
Copy link
Contributor

dmehus commented Mar 19, 2022

@Universal-Omega, thanks! Would it be helpful to add @JohnFLewis as a reviewer on this task to identify the issue?

@Universal-Omega
Copy link
Sponsor Member Author

@Universal-Omega, thanks! Would it be helpful to add @JohnFLewis as a reviewer on this task to identify the issue?

I know the issue. That's why I was able to do this PR. If I didn't know, I wouldn't be able to do it.

@dmehus
Copy link
Contributor

dmehus commented Mar 22, 2022

@Universal-Omega, thanks! Would it be helpful to add @JohnFLewis as a reviewer on this task to identify the issue?

I know the issue. That's why I was able to do this PR. If I didn't know, I wouldn't be able to do it.

Okay, thanks. Sounds good. :)

@JohnFLewis JohnFLewis merged commit e9475c7 into master Apr 3, 2022
@JohnFLewis JohnFLewis deleted the Universal-Omega-patch-1 branch April 3, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants