Improve Special:RandomWiki #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Special:RandomWiki we never want to return a closed wiki or a private one, so just remove the code to do so. (If someone later wants to do randomly select closed wikis for some reason we can just give them a copy of the cw_wikis table and some polyhedral dice.) Also all of the code was there for looking at inactive wikis or active, so I enabled that code because this might be interesting. People might only want to find active projects or try to save inactive ones.
…if available To reduce traffic, let's try doing one query with a random response instead of two queries with lots of information discarded by the application. It may be slower (I doubt it) but it will definitely reduce memory and data transfer. (Alternately we could try caching cw_wikis and choosing random on the application side, but the list of wikis will only get bigger. Apparently wiki_url is still nullable for now, but that should be the field we always use to redirect.
Universal-Omega
requested changes
Feb 23, 2024
whitespace Co-authored-by: CosmicAlpha <cosmic.alpha24@gmail.com>
whitespace Co-authored-by: CosmicAlpha <cosmic.alpha24@gmail.com>
use getType from DB handle Co-authored-by: CosmicAlpha <cosmic.alpha24@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does three main things:
Closes T11683