Remove suppress permission for flow

[ghost]

No description provided.

[JohnFLewis]

Any particular reason?

[ghost]

Deletion - which bureaucrats will hold - should be enough.

[ghost]

Besides, I don't want to purposely be adding user rights to groups that I will never have access to

[JohnFLewis]

Though keeping in mind that the oversight group will not rarely be used except requested essentially means the chances of this being used are near zero. The removal doesn't really gain anything but makes it harder in the extremely exceptional case it is ever deemed necessary meaning a steward has to assign it globally which just kills any sort of accountability really.

So on the local scale, no gain. On the global scale, a loss. Net positivity is negative so this isn't really worth merging.

[JohnFLewis]

Also an interesting scenario!

You didn't add the permissions to the oversight group - the extension did. By removing them, you're adding code so you're not really removing anything but instead adding 😉

[ghost]

@JohnFLewis The extension not only added the suppression right to the oversight group - it also created a brand new "Suppressor" user group that has this right and nothing else. It isn't really necessary to have the right in 2 different groups - neither of which I have access to - so what code would overwrite and remove the new extra group? Also, what is the purpose of the "Flow Bot" group?

[ghost]

@Reception123 Can you look at this if @JohnFLewis doesn't get to it?

[Reception123]

@DeltaQuad-DQ I would but I don't think removing the default groups created by the extension is possible, nor would I know how to do it if you could.

[ghost]

@JohnFLewis per above, do you know if removing the "Suppressor" user group is possible, since the sole permission that it has is already included in the oversight group?

[JohnFLewis]

You simply remove all permissions from the group.

[ghost]

But the group would still technically exist, right? Or could it be renamed to "null group" or something?

[ghost]

@JohnFLewis this failed entirely. The extra group still exists on the wiki.

[The-Voidwalker]

You might want to use:
unset( $wgGroupPermissions['suppress'] );

If it still exists, you can set the following to hide the group from menus:
$wgImplicitGroups[] = 'suppress';

FYI, $wgFlowGroupPermissions doesn't exist.

[ghost]

@The-Voidwalker do you have any idea how to fix https://phabricator.miraheze.org/T1211