Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLZ and city/village relationship #37

Closed
nfarabullini opened this issue Sep 3, 2018 · 4 comments
Closed

PLZ and city/village relationship #37

nfarabullini opened this issue Sep 3, 2018 · 4 comments
Assignees
@gabrielfoix
Labels
enhancement
Projects
SmaRP board

Comments

@nfarabullini
Copy link
Contributor

nfarabullini commented Sep 3, 2018 •
edited

@gabrielfoix
It would be nice to have both the postal code and the city/village displayed. However, several places might be related to the same PLZ. Do we have the data for this association available somewhere?
@nfarabullini nfarabullini added this to To do in SmaRP board via automation Sep 3, 2018
@gabrielfoix
Copy link
Contributor

gabrielfoix commented Sep 3, 2018 •
edited

Yes, would be nice. I had a similar thought time ago when dealing with the tax rate.
What do you mean by "displayed"? Show both on the inputs sidebar? I guess so.
The original info is in inst/application/data/taxdata/CorrespondancePostleitzahlGemeinde.xlsx and the already processed one in inst/application/data/PLZGemeinden.rds
At some point, could help to resolve conflicts when the same Postleitzahl applies to different Gemeinden which have different tax rate or other similar corner cases. In the script inst/postalcodes2rds.R there are some hardcoded assumptions on that regard.

@nfarabullini
Copy link
Contributor Author

Many thanks! now the app shows PLZ and Gemeinden simultaneously in the form of dropdowns. In addition, whichever is edited updates the other

@nfarabullini nfarabullini moved this from To do to Parked in SmaRP board Sep 7, 2018
riccardoporreca added a commit that referenced this issue Sep 17, 2018
@riccardoporreca
Combined PLZ and gemeinde searchable dropdown #37.
a22a063
@riccardoporreca
Copy link
Member

riccardoporreca commented Sep 20, 2018 •
edited

Pull request #44 for a single dropdown with combined PLZ + Gemeinde

riccardoporreca added a commit that referenced this issue Oct 4, 2018
@riccardoporreca
Re-generate VM via UI_Messages (#37)
b5e9d12 
* minor example cleanup with unexported function
@riccardoporreca riccardoporreca mentioned this issue Oct 4, 2018
Merged
@riccardoporreca
Copy link
Member

Closed with merge of pull request #44.

SmaRP board automation moved this from Parked to Done Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabrielfoix gabrielfoix

Labels
enhancement
Projects
SmaRP board
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gabrielfoix @riccardoporreca @nfarabullini