Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Shiny CI-CD based on current Actions status #29

Closed
riccardoporreca opened this issue Oct 29, 2021 · 0 comments · Fixed by #30
Closed

Review Shiny CI-CD based on current Actions status #29

riccardoporreca opened this issue Oct 29, 2021 · 0 comments · Fixed by #30
Assignees
@riccardoporreca

Comments

@riccardoporreca
Copy link
Member

A follow-up of #14 given how GH Actions have matured, given the introduction of composite Actions and a number of convenient actions now available in https://github.com/r-lib/actions and already integrated and tested in our example app miraisolutions/ShinyCICD#6
@riccardoporreca riccardoporreca self-assigned this Oct 29, 2021
riccardoporreca added a commit that referenced this issue Oct 29, 2021
@riccardoporreca
Fix CI/CD steps in the context of GH Actions #29
b846e85
riccardoporreca added a commit that referenced this issue Oct 29, 2021
@riccardoporreca
Align and fix redirected GitHub docs URLs #29
e688ad4 
* Redirections detected with HTMLProofer, new URLs via `curl -iv`

```sh
docker run --rm -it -v $(pwd):/src --entrypoint ruby klakegg/html-proofer -e "require 'html-proofer'" -e "
HTMLProofer.check_directory('_book/', {
  :check_external_hash => true,
  :typhoeus => {:followlocation => false}
}).run
"
```
riccardoporreca added a commit that referenced this issue Oct 29, 2021
@riccardoporreca
Pull in simplified workflows as updated in miraisolutions/ShinyCICD#6 (…
24798ad 
…#29)

Specifically, via:
```r
usethis::use_github_file(
  "miraisolutions/ShinyCICD", ref = "7a879c578be4b8faab7972a5a774da617deb08b9",
  ".github/workflows/ci-cd.yml", "shiny-ci-cd/actions/ci-cd.yml"
)
usethis::use_github_file(
  "miraisolutions/ShinyCICD", ref = "7a879c578be4b8faab7972a5a774da617deb08b9",
  ".github/workflows/ci-cd-renv.yml", "shiny-ci-cd/actions/ci-cd-renv.yml"
)
```
riccardoporreca added a commit that referenced this issue Oct 29, 2021
@riccardoporreca
Review Shiny CI/CD with Actions in light of simplified workflows #29
4b3100a 
* Includes new picture
riccardoporreca added a commit that referenced this issue Oct 29, 2021
@riccardoporreca
Fix use_github_action(), now only allowing GitHub URLs (#29)
d36ea79 
* See r-lib/usethis#1407, introduced in usethis v2.1.0
@riccardoporreca riccardoporreca mentioned this issue Oct 29, 2021
Merged
riccardoporreca added a commit that referenced this issue Oct 29, 2021
@riccardoporreca
Simplify techguides own CI/CD workflow (#29)
16dfe2d 
* Based on the `r-lib/actions/setup-r-dependencies`.
* Also include TODO about switching to `JamesIves/github-pages-deploy-action` for deployment, which is what used in `r-lib/actions/examples`.
@riccardoporreca riccardoporreca mentioned this issue Oct 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riccardoporreca riccardoporreca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Review GitHub Actions for Shiny CI/CD miraisolutions/techguides
1 participant
@riccardoporreca