Feature/14 review shiny ci cd #27

Chargothrond · 2021-04-29T13:09:41Z

Reviewed and updated shiny ci cd chapter, as well as the github actions yaml examples.
Closes #14.

…that travis ci isn't fully open source anymore

…age ^manager

fvitalini

Some minor reqording. My main request is to clarify better some steps in the yml files by adding some comments.

shiny-ci-cd.Rmd

shiny-ci-cd/actions/ci-cd.yml

shiny-ci-cd/actions/ci-renv.yml

shiny-ci-cd/actions/ci.yml

Co-authored-by: Francesca Vitalini <francesca.vitalini@mirai-solutions.com>

…ShinyCICD repo

Co-authored-by: Francesca Vitalini <francesca.vitalini@mirai-solutions.com>

Chargothrond · 2021-05-05T10:50:28Z

Thanks for the feedback @fvitalini , integrated most of it apart from the comments regarding the .yml files.

As I mentioned already in miraisolutions/ShinyCICD#1, we need to decide on how much we want to comment these files to explain them better.

@riccardoporreca Please let me know your opinion on this as well, and you can also review the changes now as I integrated Francesca's feedback.

riccardoporreca

See some refinements following the main restructuring with Actions are being the prominent part here. The main gap is talking about renv in the actions section.

.github/workflows/site.yaml

shiny-ci-cd.Rmd

Co-authored-by: Riccardo Porreca <riccardo.porreca@mirai-solutions.com>

…eem problematic in bookdown documents)

* In particular, mention the continuous deployment from `master` only, as in the Travis CI section.

* For the 4 flavors, using the `<details>` HTML tag providing implementing collapsible details.

* Missing in comparison to the Travis CI part, used as a starting point. * No specific details are included, just pointers to the renv vignette and the complete workflow files.

* Also fix the actual file content shown for each flavor

* Also including a comment

riccardoporreca · 2021-06-01T11:49:53Z

@Chargothrond, see my follow-up updates and other smaller refinements I committed.

We may want to make sure there is full alignment with the workflows as showcased in miraisolutions/ShinyCICD#1

riccardoporreca

We should also delete file .travis.yml, as Travis will not run any more and the focus is now fully on GitHub Actions

… in ShinyCICD)

Chargothrond · 2021-06-01T12:37:20Z

@riccardoporreca I have aligned the site.yml and deleted the travis.yml, let me know if anything else is required, otherwise you can go ahead with merging.

riccardoporreca

Refined comment about renv and fixed installation of remotes with renv as a final review.

I will commit the suggestions and squash-merge.

shiny-ci-cd/actions/ci-cd-renv.yml

shiny-ci-cd/actions/ci-renv.yml

shiny-ci-cd/actions/ci-cd-renv.yml

shiny-ci-cd/actions/ci-renv.yml

* Not necessarily Linux-specific * Mainly there in view of caching what we explicitly define as the renv root

* In general, we there is no guarantee of having remotes installed

Chargothrond added 4 commits April 15, 2021 13:10

move github actions section above travis ci section

889e797

review main and travis ci sections, minor changes + emphasizing more …

40b9657

…that travis ci isn't fully open source anymore

review github actions part in shiny ci cd

3f14be2

update and align example yamls to latest features like RStudio's pack…

9a7a4ab

…age ^manager

Chargothrond requested review from fvitalini and riccardoporreca April 29, 2021 13:09

Chargothrond mentioned this pull request Apr 29, 2021

Review Shiny CI/CD #14

Closed

fvitalini suggested changes May 4, 2021

View reviewed changes

Chargothrond and others added 10 commits May 5, 2021 12:21

Update shiny-ci-cd.Rmd

dd1be80

Co-authored-by: Francesca Vitalini <francesca.vitalini@mirai-solutions.com>

Update shiny-ci-cd.Rmd

46b845c

Co-authored-by: Francesca Vitalini <francesca.vitalini@mirai-solutions.com>

Update shiny-ci-cd.Rmd

2ba4442

Co-authored-by: Francesca Vitalini <francesca.vitalini@mirai-solutions.com>

Update shiny-ci-cd.Rmd

0610193

Co-authored-by: Francesca Vitalini <francesca.vitalini@mirai-solutions.com>

remove bad article and align comment in yamls to what was changed in …

b00f4f2

…ShinyCICD repo

Update shiny-ci-cd.Rmd

1dba295

Co-authored-by: Francesca Vitalini <francesca.vitalini@mirai-solutions.com>

Update shiny-ci-cd.Rmd

7705a1f

Co-authored-by: Francesca Vitalini <francesca.vitalini@mirai-solutions.com>

Update shiny-ci-cd.Rmd

8c13a72

Co-authored-by: Francesca Vitalini <francesca.vitalini@mirai-solutions.com>

Update shiny-ci-cd.Rmd

f0b59ae

Co-authored-by: Francesca Vitalini <francesca.vitalini@mirai-solutions.com>

make run logs sentence clearer

6db88bb

Chargothrond requested a review from fvitalini May 5, 2021 10:48

fvitalini approved these changes May 5, 2021

View reviewed changes

mention that these actions can be sources / taken from specific repos

78c99ef

riccardoporreca requested changes May 7, 2021

View reviewed changes

Chargothrond and others added 7 commits May 10, 2021 10:15

Update .github/workflows/site.yaml

ead4ee0

Co-authored-by: Riccardo Porreca <riccardo.porreca@mirai-solutions.com>

Update shiny-ci-cd.Rmd

017eda2

Co-authored-by: Riccardo Porreca <riccardo.porreca@mirai-solutions.com>

Update shiny-ci-cd.Rmd

e4614f2

Co-authored-by: Riccardo Porreca <riccardo.porreca@mirai-solutions.com>

Update shiny-ci-cd.Rmd

1938ecf

Co-authored-by: Riccardo Porreca <riccardo.porreca@mirai-solutions.com>

Update shiny-ci-cd.Rmd

04b4aad

Co-authored-by: Riccardo Porreca <riccardo.porreca@mirai-solutions.com>

Update shiny-ci-cd.Rmd

5bb9752

Co-authored-by: Riccardo Porreca <riccardo.porreca@mirai-solutions.com>

Update shiny-ci-cd.Rmd

c4d9e53

Co-authored-by: Riccardo Porreca <riccardo.porreca@mirai-solutions.com>

Chargothrond and others added 12 commits May 10, 2021 10:29

Update shiny-ci-cd.Rmd

3908207

Co-authored-by: Riccardo Porreca <riccardo.porreca@mirai-solutions.com>

Update shiny-ci-cd.Rmd

395be69

Co-authored-by: Riccardo Porreca <riccardo.porreca@mirai-solutions.com>

Update shiny-ci-cd.Rmd

cbaede2

Co-authored-by: Riccardo Porreca <riccardo.porreca@mirai-solutions.com>

Update shiny-ci-cd.Rmd

bc8f21b

Co-authored-by: Riccardo Porreca <riccardo.porreca@mirai-solutions.com>

integrating some of the feedback (except collapsible sections which s…

be7bae1

…eem problematic in bookdown documents)

Improve GitHub actions "Deployment" section

2c29453

* In particular, mention the continuous deployment from `master` only, as in the Travis CI section.

Include collapsed complete workflow files

19b455d

* For the 4 flavors, using the `<details>` HTML tag providing implementing collapsible details.

Include renv section for GitHub Actions

900444e

* Missing in comparison to the Travis CI part, used as a starting point. * No specific details are included, just pointers to the renv vignette and the complete workflow files.

Rephrase skipped deployment comment to GH Actions screenshot

ee637ff

Collapsible Actions WFs using file name as summary

24f7b5d

* Also fix the actual file content shown for each flavor

Align renv-based actions WF to enable colorful R CMD check

d898546

Extend continuous deployment from the main branch

416990e

* Also including a comment

riccardoporreca mentioned this pull request Jun 1, 2021

Feature/update ghwfs yaml miraisolutions/ShinyCICD#1

Merged

riccardoporreca requested changes Jun 1, 2021

View reviewed changes

integrate feedback from Riccardo (align also comments that were added…

832af31

… in ShinyCICD)

riccardoporreca approved these changes Jun 1, 2021

View reviewed changes

shiny-ci-cd/actions/ci-cd-renv.yml Outdated Show resolved Hide resolved

shiny-ci-cd/actions/ci-renv.yml Outdated Show resolved Hide resolved

shiny-ci-cd/actions/ci-cd-renv.yml Show resolved Hide resolved

shiny-ci-cd/actions/ci-renv.yml Show resolved Hide resolved

riccardoporreca added 2 commits June 1, 2021 17:16

Improve comment about RENV_PATHS_ROOT

3cdfc3e

* Not necessarily Linux-specific * Mainly there in view of caching what we explicitly define as the renv root

Make sure to install remotes with renv for the sys deps

740e202

* In general, we there is no guarantee of having remotes installed

riccardoporreca self-assigned this Jun 1, 2021

riccardoporreca merged commit e872999 into master Jun 1, 2021

riccardoporreca deleted the feature/14-review-shiny-ci-cd branch June 1, 2021 15:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/14 review shiny ci cd #27

Feature/14 review shiny ci cd #27

Chargothrond commented Apr 29, 2021 •

edited by riccardoporreca

Loading

fvitalini left a comment

Chargothrond commented May 5, 2021

riccardoporreca left a comment

riccardoporreca commented Jun 1, 2021

riccardoporreca left a comment

Chargothrond commented Jun 1, 2021

riccardoporreca left a comment

Feature/14 review shiny ci cd #27

Feature/14 review shiny ci cd #27

Conversation

Chargothrond commented Apr 29, 2021 • edited by riccardoporreca Loading

fvitalini left a comment

Choose a reason for hiding this comment

Chargothrond commented May 5, 2021

riccardoporreca left a comment

Choose a reason for hiding this comment

riccardoporreca commented Jun 1, 2021

riccardoporreca left a comment

Choose a reason for hiding this comment

Chargothrond commented Jun 1, 2021

riccardoporreca left a comment

Choose a reason for hiding this comment

Chargothrond commented Apr 29, 2021 •

edited by riccardoporreca

Loading