Run tests with a readonly library on CRAN #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoltier
commented
Apr 23, 2024
wrong directory, copy-paste from solution
spoltier
force-pushed
the
feature/readonly-tests-cran-compliance
branch
from
eb87e7e
to
b8c5656
Compare
spoltier
force-pushed
the
feature/readonly-tests-cran-compliance
branch
from
7ab3a4b
to
018c8de
Compare
martinstuder
approved these changes
Apr 24, 2024
spoltier
force-pushed
the
feature/readonly-tests-cran-compliance
branch
from
a8ac5bf
to
018c8de
Compare
|
@martinstuder tried to do a check for files added to the library after installation, but there is no option to do this with the R check action, and the action itself either cleans up or uses its own R lib. I checked locally on multiple machines, that should suffice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a new CRAN check, running the package check with a readonly R library.
See https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-clang/XLConnect-00check.html and https://github.com/kalibera/cran-checks/tree/master/rlibro/results/XLConnect.
→ Avoid any writes in the non-FULL case, including writing the unit tests results.