KeepStatus: option "Reconnect on APM resume" don't work

[dartraiden]

No description provided.

[Goraf]

Looks like protoList keeps wrong status of protocols (seems like they aren't updated)
After

miranda-ng/plugins/StatusManager/src/KeepStatus/keepstatus.cpp

Line 1068 in 18d362a

ps = GetCurrentProtoSettingsCopy();

ps[i]->m_status is equal to ID_STATUS_DISABLED so when it comes to reestablish connection after APM resume

miranda-ng/plugins/StatusManager/src/KeepStatus/keepstatus.cpp

Lines 1078 to 1088 in 18d362a

	case PBT_APMRESUMESUSPEND:
	case PBT_APMRESUMECRITICAL:
	log_infoA("KeepStatus: resume from suspend state");
	if (ps != nullptr) {
	for (int i = 0; i < protoList.getCount(); i++)
	protoList[i].AssignStatus(ps[i]->m_status, ps[i]->m_lastStatus, ps[i]->m_szMsg);
	FreeProtoSettings(ps);
	ps = nullptr;
	}
	StartTimer(IDT_PROCESSACK, 0, FALSE);
	break;

it fails to assign previous status, returning early

miranda-ng/plugins/StatusManager/src/KeepStatus/keepstatus.cpp

Lines 165 to 168 in 18d362a

	int SMProto::AssignStatus(int iStatus, int iLastStatus, wchar_t *pwszMsg)
	{
	if (iStatus < MIN_STATUS || iStatus > MAX_STATUS)
	return -1;

[WalrusInAnus]

This really makes Miranda useless for me. My PC goes to sleep quite often, and it's permanent disconnected hell for me.

[Larusek]

Indeed it is. What's more disappointing, it has been 24 days and no one assigned to this bug. Is it being worked on at all?

[WalrusInAnus]

It's still bugged for me :( I haven't even put my PC to sleep, and I've just noticed I'm offline again.
What kind of log should I provide for you to be able to troubleshoot this further?

[Goraf]

I haven't even put my PC to sleep, and I've just noticed I'm offline again.

@WalrusInAnus , but it's sth different than this ticket is about. Let all of us don't mix up things. Every option can be not working on its own. For general case of not reconnecting there was a separate ticket next to this one (#1150). If you have problem with basic feature go report there, or in both places if you also confirm that this is still not working.

First, make sure you updated Miranda to the latest development version. The next thing to check/provide are entries from KeepStatus in network log. You can create standalone report (link int the second ticket), or see them on the fly using Console plugin. And just in case recheck your options.

[Larusek]

Thank you for the fix. It's solved.