Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable hashid alphabet + hashMinLength to be configured #3

Merged
merged 2 commits into from
Nov 25, 2019

Conversation

oddnavy
Copy link
Contributor

@oddnavy oddnavy commented Nov 19, 2019

We needed to adjust the hashid config when working on a project. This PR adds the ability to change the hashid alphabet and min hash length

@rungta
Copy link
Member

rungta commented Nov 20, 2019

Thank you for the pull request @oddnavy! It’ll be great if you can make the following minor edits:

  • Let the default alphabet config value be null
  • Only pass a third argument to the Hashids() constructor if we have a non-null $this->alphabet value
  • Undo whitespace changes

@oddnavy oddnavy force-pushed the feature/additional-config-options branch from f2758be to e764970 Compare November 22, 2019 00:19
@oddnavy
Copy link
Contributor Author

oddnavy commented Nov 22, 2019

No worries @rungta. I've pushed some changes.

Only pass a third argument to the Hashids() constructor if we have a non-null $this->alphabet value

How would recommend doing ☝️

@rungta rungta merged commit 9a2d475 into miranj:v1 Nov 25, 2019
rungta added a commit that referenced this pull request Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants