Fine tune UIView.pin.safeArea support for iOS 8 and "New Relic" framework #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 22, 2018 08:04
…9/10. * Fix a possible conflict iOS 8 conflict with the device's keyboard. * Add a way to bypass a conflict with the New Relic iOS framework.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update PinLayout initialization.
On iOS 8, PinLayout compatibility support of
UIView.safeAreaInsetsDidChangewas causing issues with the device's virtual keyboard. PinLayout still supportUIView.pin.safeAreaon this iOS release, butUIView.safeAreaInsetsDidChangewon't be called on iOS 8Fix issue with "New Relic" framework: Add a
Pin.initPinLayout()that can be called to initialize PinLayout before the "New Relic" framework is initialized. "New Relic" is conflicting with other popular frameworks including Mixpanel, ReactiveCocoa, Aspect, ..., and PinLayout. To fix the issue,Pin.initPinLayout()must be called BEFORE initializing "New Relic" with NewRelic.start(withApplicationToken:"APP_TOKEN"). See here for more information regarding this issue Crash in iOS 10.2.1 #130