Fix the build_payload

[scottming]

After Absinthe 1.4, only update the value is not enough, we also need to update the errors.

[simonprev]

Can you add a test to see what was the problem with the behaviour before your changes? We run absinthe_error_payload on many project and we never encountered a bug with the current behaviour 😃

[scottming]

Hi, @simonprev , writing a test to show the problem is hard, but I know why the build_payload not work, but I can give you a demo: https://github.com/scottming/plate_slate/blob/master/test/plate_slate_web.

[scottming]

You can check this test to reproduce the problem.

https://github.com/scottming/plate_slate/blob/master/test/plate_slate_web/schema/mutation/create_menu_item_returns_payload_test.exs

They are the same logic, but the first test not work, and the second works. The difference is the first uses build_payload/1 middleware way, and the second uses the manual way.

So, I think the problem is we need to update the errors to [] after resolve middleware, and the tests of this lib not recovered it.

500f7fa

[jeregrine]

Tested this change locally and it fixes issue #15

[rwngallego]

@simonprev is it possible to approve this one? The package is totally broken at this moment with the latest Absynthe version.

[simonprev]

Just published 1.1.2 with the changes in this PR 🎉

[maennchen]

This Merge Request produces problems for me using absinthe 1.4.16.

Our app handles mutation errors and global errors differently. Before this change, a Middleware could write into the Absinthe.Resolution{errors} and the error would be sent directly to the user. Now the user instead gets an ok response with successful false.

If this is expected behavior, I would expect a breaking change in the versioning.

[maennchen]

Example Middleware in Question:

defmodule Acme.Schema.Middleware.CheckAuthenticationRequired do
  @moduledoc false

  @behaviour Absinthe.Middleware

  def call(
        %Absinthe.Resolution{context: %{creator_subject: creator_subject}} = resolution,
        callback
      )
      when is_function(callback, 1) and not is_nil(creator_subject) do
    resolution
  end

  def call(resolution, callback) when is_function(callback, 1) do
    if callback.(resolution),
      do: Absinthe.Resolution.put_result(resolution, {:error, "Unauthenticated"}),
      else: resolution
  end
end

[ppff]

This PR indeed broke 10% of our unit tests. We'll stick to v1.1.1 for now.