Add handling for atoms as error messages #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ACBullen
force-pushed
the
handle_atom_errors
branch
from
4ad50ae
to
c567cd5
Compare
or as lists by interpolating them into strings
ACBullen
force-pushed
the
handle_atom_errors
branch
from
c567cd5
to
3c6a394
Compare
garno
reviewed
Mar 12, 2020
Co-Authored-By: Samuel Garneau <sam@garno.me>
|
It's been a while. Any idea whether or not this PR is worthwhile and merge-able? Anything I can do to improve it? Should it be shelved? |
|
That looks good to me! Sorry about the delay 😬 |
|
Thank you for maintaining the package! It's been super useful 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my experience, it's not uncommon for error tuples like
{:error, :unauthorized}to be passed around in an application and since in a lot of cases that is a sufficiently explanatory message for the error, having this library take care of intercepting and stringifying those errors would be a nice-to-have that would be fairly easy to implement