Map :options Keyword List into a Map #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed private function for opts
suppayami
force-pushed
the
options-to-map
branch
from
286ecd6
to
a4d370f
Compare
|
@simonprev would you mind taking a look at this? |
|
Is this happening anytime soon? |
|
Closed by #13 🎉 |
|
thanks for the amazing work! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently :options field is a Keyword List, which is not encode-able by some JSON encoders (ie. Jason). Converting Keyword List into a Map would make it serialisable and readable from client-side.