Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field suggestions phase and tests #3

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

matkev
Copy link
Contributor

@matkev matkev commented Dec 5, 2023

📖 Description and reason

Add phase for disabling field suggestions, as in tnse.

🦀 Dispatch

#dispatch/elixir

@remi
Copy link
Member

remi commented Dec 5, 2023

Cool! I think this PR should also update this part of README.md.

@MathieuLegault1
Copy link
Contributor

Cool! I think this PR should also update this part of README.md.

I still need to add the new introspection check that I added yesterday. I was also thinking of changing the layout of the README after since I feel it's kinda hard to read.

@remi
Copy link
Member

remi commented Dec 5, 2023

I was also thinking of changing the layout of the README after since I feel it's kinda hard to read.

Yes, that was on my todo list as well. Providing a more thorough example for each module to show how it should be used.

@matkev matkev merged commit b942db0 into main Dec 5, 2023
8 checks passed
@matkev matkev deleted the feature/disable-field-suggestions branch December 5, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants