Optimise queries #31
Merged
Optimise queries #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauleth
force-pushed
the
optimise-queries
branch
from
77d581d
to
674672f
Compare
hauleth
force-pushed
the
optimise-queries
branch
from
07b0482
to
dbfd681
Compare
|
It seems that there is race condition in test suite which causes the problems with build passing. |
hauleth
force-pushed
the
optimise-queries
branch
2 times, most recently
from
566118d
to
cfd0b4f
Compare
|
It will be hard for me to increase coverage in this PR as the decrease is due to fact that I have removed bunch of lines and that caused overall coverage fall, each separate file coverage is left as is. |
simonprev
reviewed
May 7, 2018
.tool-versions
Outdated
| @@ -0,0 +1 @@ | |||
| elixir 1.6.1 | |||
There was a problem hiding this comment.
This should not be commited since we can’t assume what the developer will use to manage elixir and erlang dependancies.
Inner join is default join for Ecto for valid reasons, it helps DB optimizer to reduce amount of tuples fetched from storage.
A lot of indices through whole DB were missing. While some of them are overlapping with existing mutlicolumn indices the order of columns is wrong, as most specific ones are first and least specific (and by that most used) are last which mean that DB cannot use them in queries.
Trigram indices are built-in extension to PostgreSQL which greatly improve non-contextual text search queries where search query is longer than 3 characters by building index of 3 characters blocks in each entry. As this is built-in this do not require any additional installation.
Old way required 2 DB queries, where one would be sufficient.
|
All requests resolved. |
simonprev
approved these changes
May 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is overall review of the DB status. More details in commit messages.