Use name instead of event_name in metric uniqueness in Reporter #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using the `event_name` as a unique_identifier when determining when event is unique, we change it so that it now uses the `name`. The change is needed since in certain case we want to measure the same event_name in multiple ways. This happens when using the keep or old function to discard some events. For example, in the telemetry_metrics hexdoc we have this
```elixir
distribution(
"http.client.request.duration",
event_name: [:http_client, :request, :stop],
drop: &(match?(%{name: :fast_client}, &1))
)
distribution(
"http.fast.client.request.duration",
event_name: [:http_client, :request, :stop],
keep: &(match?(%{name: :fast_client}, &1))
)
```
As we can see, the same event_name is used twice which would be merged together at the moment. Since we need to log them individually, we need to use the `name` instead of `event_name`
|
Since this is a breaking change, I just released version 2.0 that address this issue 🎉 I also added instructions in the README: https://github.com/mirego/telemetry_ui#20-breaking-change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the
event_nameas a unique_identifier when determining when event is unique, we change it so that it now uses thename. The change is needed since in certain case we want to measure the same event_name in multiple ways. This happens when using the keep or old function to discard some events. For example, in the telemetry_metrics hexdoc we have this:As we can see, the same event_name is used twice which would be merged together at the moment. Since we need to log them individually, we need to use the
nameinstead ofevent_name