Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VMDTextField parameter not used in the implementation #218

Merged
merged 4 commits into from Feb 12, 2024

Conversation

Vincent-Ribou
Copy link
Contributor

Description

I added a check if a placeholder is passed to the function, if it is the case we use the placeholder instead of the Text.

Motivation and Context

In the VMDTextField we have a placeholder parameter, but it was not used in the implementation.
It was impossible to have a custom placeholder for the VMDText since what we passed to the TextField was a simple Text with a style. I ran in a case where my text input was on a single line, but the placeholder was on multiple lines. Being able to set a placeholder will solve this case and make the VMDTextField more flexible.

How Has This Been Tested?

I tested this change in a project. I tested the function by passing a placeholder as parameter.
I also tested without a parameter to make sure everything still work correctly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@Vincent-Ribou Vincent-Ribou merged commit 679ce09 into master Feb 12, 2024
1 check passed
@Vincent-Ribou Vincent-Ribou deleted the fix/vmdtext-field-placeholder branch February 12, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants