Fix VMDTextField parameter not used in the implementation #218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added a check if a placeholder is passed to the function, if it is the case we use the placeholder instead of the Text.
Motivation and Context
In the VMDTextField we have a placeholder parameter, but it was not used in the implementation.
It was impossible to have a custom placeholder for the VMDText since what we passed to the TextField was a simple Text with a style. I ran in a case where my text input was on a single line, but the placeholder was on multiple lines. Being able to set a placeholder will solve this case and make the VMDTextField more flexible.
How Has This Been Tested?
I tested this change in a project. I tested the function by passing a placeholder as parameter.
I also tested without a parameter to make sure everything still work correctly.
Types of changes