Added simple view for single fields #26
Open
+125
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mireo91
requested changes
May 8, 2024
|
@mireo91 I'm sorry. I forgot to push the changes. It should be visible now. :) |
|
Nice one |
|
I will review and merge this weekend |
jonnitto
suggested changes
May 14, 2024
Resources/Private/Backend/RepeatableField/src/View/Repeatable.js
Outdated
Show resolved
Hide resolved
|
@jonnitto Done |
jonnitto
reviewed
Jun 3, 2024
Resources/Private/Backend/RepeatableField/src/View/Repeatable.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Jon Uhlmann <account@uhlmann.pro>
|
@jonnitto Is there still something I can improve or is it ready to be merged? |
|
No, we've to wait for @mireo91 |
|
@jonnitto as I understand you tested it on your side (I dont have much time to see it myself - my wife got pregnant and I am renovating house after work) could you confirm me that it is safe to marge without my involvement - I will do it then right away. |
|
@vcg-development The fields looks a bit unaligned. I think there is some more CSS work needed… CleanShot.2024-06-18.at.12.55.08.mp4 |
We'll have a look at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a minimalistic view if you just need a single repeatable field instead of a group of fields.