Skip to content

Commit

Permalink
extmod/modssl_mbedtls: Ignore err ERR_SSL_RECEIVED_NEW_SESSION_TICKET.
Browse files Browse the repository at this point in the history
It appears a new session ticket being issued by the server right after
completed handshake is not uncommon and shouldn't be treated as fatal.

mbedtls itself states "This error code is experimental and may be changed
or removed without notice."

Signed-off-by: Mirko Vogt <mirko-dev|mpy@nanl.de>
  • Loading branch information
Mirko Vogt authored and dpgeorge committed Sep 3, 2023
1 parent 1b03518 commit 65f0cb1
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions extmod/modssl_mbedtls.c
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,14 @@ STATIC mp_uint_t socket_read(mp_obj_t o_in, void *buf, mp_uint_t size, int *errc
// renegotiation.
ret = MP_EWOULDBLOCK;
o->poll_mask = MP_STREAM_POLL_WR;
#if defined(MBEDTLS_SSL_PROTO_TLS1_3)
} else if (ret == MBEDTLS_ERR_SSL_RECEIVED_NEW_SESSION_TICKET) {
// It appears a new session ticket being issued by the server right after
// completed handshake is not uncommon and shouldn't be treated as fatal.
// mbedtls itself states "This error code is experimental and may be
// changed or removed without notice."
ret = MP_EWOULDBLOCK;
#endif
} else {
o->last_error = ret;
}
Expand Down

0 comments on commit 65f0cb1

Please sign in to comment.