Skip to content

Commit

Permalink
Update TODO references: #27, #28, #29, #30, #31, #32, #33, #34, #35, #36
Browse files Browse the repository at this point in the history
, #37, #38, #39, #40, #41, #42
  • Loading branch information
todo-actions[bot] committed Feb 9, 2021
1 parent 4666a36 commit 7b84376
Show file tree
Hide file tree
Showing 11 changed files with 16 additions and 16 deletions.
2 changes: 1 addition & 1 deletion src/scenes/CharacterSheet/Downtime/Downtime.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const Downtime: React.FC<Props> = (props) => {
<Layout style={styles.container}>
<Divider />
<ScrollView>
{/* TODO [$6021f0207b27d600084dbee1]: Make the text here prettier */}
{/* TODO [#27]: Make the text here prettier */}
<PrepareSpellsActivity />
<BribeAContactActivity />
<CostOfLivingActivity />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export type EditArmorNavigationProps = StackNavigationProp<
DefenseStackParamList,
"EditWornArmor"
>;
// TODO [$6021f0207b27d600084dbee2]: Make Worn Armor a selectable list of Armor in the Inventory
// TODO [#28]: Make Worn Armor a selectable list of Armor in the Inventory
const EditWornArmor: React.FC<Props> = (props) => {
const [input, setInput] = useState({
name: props.wornArmor.name,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import { MainDefenseNavigationProps } from "../../DefenseNavigation";
import { EncounterDefenseNavigationProps } from "../../EncounterNavigator";
import { CharacterSheetEncounterTabNavigationProps } from "../../../CharacterSheet";

// TODO [$6021f0207b27d600084dbee3]: Equip Shield selector. DropDown?
// TODO [#29]: Equip Shield selector. DropDown?
const ShieldView: React.FC<Props> = (props) => {
if (props.wornShields === undefined) {
return <></>;
Expand Down
2 changes: 1 addition & 1 deletion src/scenes/CharacterSheet/Encounter/EncounterNavigator.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export type EncounterOffenseNavigationProps = BottomTabNavigationProp<
>;

const EncounterNavigator: React.FC<Props> = (props) => {
// TODO [$6021f0207b27d600084dbee4]: Convert bottom tab to swipeable carousel
// TODO [#30]: Convert bottom tab to swipeable carousel
const Tab = createBottomTabNavigator<EncounterTabParamList>();
// @ts-ignore
const BottomTabBar = ({ navigation, state }) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ import {
} from "../../../../../PF2eCoreLib/PlayerCharacter";
import Store from "../../../../../store/Store";

// TODO [$6021f0207b27d600084dbee5]: Write TESTS for WeaponHelper.ts!
// TODO [#31]: Write TESTS for WeaponHelper.ts!
export function GetProficiencyForWeapon(weapon: Weapon): Proficiencies {
const state = Store.getState();
const proficiencies = state.playerCharacter.weaponProficiencies;
switch (weapon.weaponCategory) {
case "Other":
proficiencies.Other.forEach((customProficiency) => {
// TODO [$6021f0207b27d600084dbee6]: Make Other weapon proficiency and weapon name not need to match
// TODO [#32]: Make Other weapon proficiency and weapon name not need to match
// i.e.Currently you need to have +1 Shortsword as a weapon name and Other proficiency for it to match here.
// This will be tricky.
if (customProficiency.description === weapon.name) {
Expand Down
4 changes: 2 additions & 2 deletions src/scenes/CharacterSheet/Encounter/Skills/SkillsView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ const SkillsView: React.FC<Props> = (props) => {
setState({});
}, [])
);
// TODO [$6021f0207b27d600084dbee7]: Handle Lore Skills
// TODO [$6021f0207b27d600084dbee8]: Add/Delete Lore Skills
// TODO [#33]: Handle Lore Skills
// TODO [#34]: Add/Delete Lore Skills
const renderItem = (item: Skill) => {
const index = indexOf(props.skills, item);
const handleSkillTouch = () => {
Expand Down
2 changes: 1 addition & 1 deletion src/scenes/CharacterSheet/Exploration/Exploration.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import SearchActivity from "./Components/SearchActivity";
type Props = {};

const Exploration: React.FC<Props> = (props) => {
/* TODO [$6021f0207b27d600084dbee9]: Make the text display prettier for Exploration Page */
/* TODO [#35]: Make the text display prettier for Exploration Page */
return (
<Layout>
<ScrollView>
Expand Down
4 changes: 2 additions & 2 deletions src/scenes/CharacterSheet/Inventory/Components/EditDie.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export const EditDie: React.FC<Props> = (props) => {
value={die.formula}
size="medium"
onChangeText={(text) => {
// TODO [$6021f0207b27d600084dbeea]: Validate DiceFormula
// TODO [#36]: Validate DiceFormula
setDie({ ...die, formula: text });
}}
onBlur={onBlur}
Expand All @@ -53,7 +53,7 @@ export const EditDie: React.FC<Props> = (props) => {
value={die.damageType}
size="medium"
onChangeText={(text) => {
// TODO [$6021f0207b27d600084dbeeb]: Validate Damage type
// TODO [#37]: Validate Damage type
setDie({ ...die, damageType: text });
}}
onBlur={onBlur}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ const EditItem: React.FC<Props> = (props) => {
isShield,
};
});
// TODO [$6021f0207b27d600084dbeec]: Use this on all forms. Disable the update button if things are being typed.
// TODO [#38]: Use this on all forms. Disable the update button if things are being typed.
// const [isKeyboardVisible, setKeyboardVisible] = useState(false);
// useEffect(() => {
// const keyboardDidShowListener = Keyboard.addListener(
Expand Down
6 changes: 3 additions & 3 deletions src/scenes/CharacterSheet/Inventory/Components/EditWeapon.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export const EditWeapon: React.FC<Props> = (props) => {
const handleWeaponCategorySelect = (index: IndexPath | IndexPath[]) => {
const trueIndex = index as IndexPath;
let category: keyof WeaponProficiencies | undefined;
// TODO [$6021f0207b27d600084dbeed]: Handle Editing of Other Category properties. i.e description and mapping description to weapon proficiency.
// TODO [#39]: Handle Editing of Other Category properties. i.e description and mapping description to weapon proficiency.
switch (weaponCategoryData[trueIndex.row]) {
case weaponCategoryData[0]:
category = "Unarmed";
Expand Down Expand Up @@ -170,7 +170,7 @@ export const EditWeapon: React.FC<Props> = (props) => {
Weapon Properties
</Text>
{
// TODO [$6021f0207b27d600084dbeee]: Enrich View with basic weapon stat breakdown calculations and summary
// TODO [#40]: Enrich View with basic weapon stat breakdown calculations and summary
}
<Select
value={props.state.item.weaponCategory}
Expand All @@ -191,7 +191,7 @@ export const EditWeapon: React.FC<Props> = (props) => {
style={{ flex: 1, paddingHorizontal: 5, paddingVertical: 5 }}
/>
{
// TODO [$6021f0207b27d600084dbeef]: Enrich Selection data with ability modifier in dropdown
// TODO [#41]: Enrich Selection data with ability modifier in dropdown
}
<Select
value={props.state.item.ability}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const EditWeaponProficiencyView: React.FC<Props> = (props) => {
const [input, setInput] = useState<WeaponProficiencies>(
props.weaponProficiencies
);
// TODO [$6021f0207b27d600084dbef0]: Use Navigation listener with local state to update redux.
// TODO [#42]: Use Navigation listener with local state to update redux.
// const navigation = useNavigation();
// useEffect(() => {
// navigation.addListener("beforeRemove", (event) => {
Expand Down

0 comments on commit 7b84376

Please sign in to comment.